WIP: Implement Vim key bindings. #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thank you for this addon! I have been using it for many years now.
I recently searched for a possibility to control the NoScript permissions menu with Vim key bindings (i.e. h,j,k,l) instead of arrow keys.
As this is not possible yet, I have implemented a solution.
Are you generally open to have this merged upstream so other users can benefit from this as well?
I could only find issue #219 that seems related to this PR. Though I believe there might actually be some more users that could find this key binding useful.
If you are open to this PR, there might be a few changes still required, that's why i marked this as WIP for now.
As this implementation tries to mimic the native radio button movement, it can be different for only a few cases (e.g. when on the "Custom" button or in private mode).
I think this should be approached by either adjusting the new key bindings some more, merging both to the exact same behavior (with
ArrowLeftandArrowRightcases added), or ideally both.Maybe there is even a better way to just have a setting that maps
ArrowLeft/ArrowRighttoKeyH/KeyL? I could not find one though.I have only tested this on Firefox 107/108 so far.